Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Use a qualified release name for sentry and deployments #1428

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 19, 2022

The Sentry SDK used to report relay-log@<version> as release name, while the
deployment script used the commit SHA. To align the two, we now follow the
Sentry convention of relay@<version>+<sha> in both cases.

In Sentry, this renders as:

image

@jan-auer jan-auer requested a review from a team August 19, 2022 10:20
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jan-auer jan-auer enabled auto-merge (squash) August 19, 2022 10:58
@jan-auer jan-auer merged commit bb14c59 into master Aug 19, 2022
@jan-auer jan-auer deleted the fix/sentry-release branch August 19, 2022 11:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants