feat(replays): Add looser type requirements for the user.id field #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFerge
reviewed
Aug 31, 2022
JoshFerge
approved these changes
Aug 31, 2022
olksdr
approved these changes
Sep 1, 2022
| @@ -147,7 +147,7 @@ struct VersionedMeta { | |||
|
|
|||
| #[derive(Debug, Default, Deserialize, Serialize)] | |||
| struct User { | |||
| id: Option<String>, | |||
| id: Option<Value>, | |||
There was a problem hiding this comment.
Just a quick question: is User ID can be anything or is there an agreed upon definition of how the user should looks like?
There was a problem hiding this comment.
String or number. Mostly I'm just not concerned with validating it here. At least not yet. I want to allow anything for now and let the snuba consumer sort it out.
I want to use relay_general::protocol::user::User but it was a little difficult to integrate and its something I want to come back to. If you have any tips for utilizing it let me know.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip validation of the user.id field. We will validate on the consumer side with the intent of adding stricter validation to relay in the future.