Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(quotas): Use correct string spelling for TransactionProcessed #1514

Merged
merged 5 commits into from
Oct 6, 2022
Merged

fix(quotas): Use correct string spelling for TransactionProcessed #1514

merged 5 commits into from
Oct 6, 2022

Conversation

flub
Copy link
Contributor

@flub flub commented Oct 5, 2022

Serde was (de)serialising this wrongly leading to inconsistencies.

fix(quotas): Use correct string spelling for TransactionProcessed
a34a260 
Serde was (de)serialising this wrongly leading to inconsistencies.
@flub flub requested a review from a team October 5, 2022 13:30
jjbayer
jjbayer approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C ABI seems to use name() and from_name() (via FromStr), so this looks good to e.

iker-barriocanal
iker-barriocanal approved these changes Oct 5, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@flub flub enabled auto-merge (squash) October 5, 2022 15:58
@flub flub merged commit 70d5b63 into master Oct 6, 2022
@flub flub deleted the flub/datacategory-naming branch October 6, 2022 10:37
jan-auer added a commit that referenced this pull request Oct 7, 2022
@jan-auer
Merge branch 'master' into feat/metrics-enforce-quotas
b7bd8e0 
* master:
  fix(quotas): Make redis rate limiter work with quantity 0 (#1519)
  ref: Remove unused rate_limits from ProcessEnvelopeState (#1516)
  fix(quotas): Use correct string spelling for TransactionProcessed (#1514)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@olksdr olksdr olksdr approved these changes

@jjbayer jjbayer jjbayer approved these changes

Assignees

@jjbayer jjbayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flub @jjbayer @olksdr @iker-barriocanal