fix(server): Drop transactions outside of the metrics time range #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
changed the title
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay used to accept transactions back-dated up to 30 days into the
past, but transaction metrics are restricted to 5 days, a restriction
which our storage relies on. With this PR, metric extraction now
validates the transaction timestamps and does not extract metrics if the
timestamp is outside the allowed range for metrics.
Additionally, Relay also needs to drop the transaction event for
consistency between metrics and events. Otherwise, a transaction may be
indexed that is not included in the "total" metrics dataset. This would
lead to inconsistency between the datasets and violate an invariant that
metrics contain a superset of indexed transactions.
Ref #1630