fix: Bugs in array trimming, more code comments #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
force-pushed
the
fix/trimming-bugs
branch
from
7d3af56
to
ad4de00
Compare
mitsuhiko
reviewed
Jan 29, 2019
jan-auer
reviewed
Jan 29, 2019
| @@ -432,6 +432,7 @@ pub struct MetaInner { | |||
|
|
|||
| impl MetaInner { | |||
| pub fn is_empty(&self) -> bool { | |||
| // TODO(jan): Evaluate which meta info is relevant enough to keep if the value is gone. | |||
There was a problem hiding this comment.
@mitsuhiko @untitaker This is for a follow-up PR. I would argue that we should always be able to add original_length without worrying about serializing a Meta node. If only original_length is set but no errors or remarks, then no meta tree should be serialized for this path. This would slim down meta generated for trimmed structures.
This comment has been minimized.
This comment has been minimized.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.