Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Added lang to frame and stacktrace #186

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Conversation

mitsuhiko
Copy link
Member

This adds a lang attribute to frame and stacktrace which is going to be used
to permit language specific handling.

@codecov-io
Copy link

Codecov Report

Merging #186 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   64.68%   64.69%   +<.01%     
==========================================
  Files          83       83              
  Lines        9004     9006       +2     
==========================================
+ Hits         5824     5826       +2     
  Misses       3180     3180
Impacted Files Coverage Δ
general/src/protocol/stacktrace.rs 96.72% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355f16e...9c63d1e. Read the comment docs.

Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, although it would be good to get "standard" names for our known languages typed out in an enum. Should also align with Language in symbolic. Could be an enum with an Other variant then.

@mitsuhiko
Copy link
Member Author

I was considering this but for now i only want that mapping in Python.

@mitsuhiko mitsuhiko merged commit b6d0ea7 into master Mar 16, 2019
@mitsuhiko mitsuhiko deleted the feature/add-lang branch March 16, 2019 21:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants