Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(profiling): Add javascript platform #1876

Merged
merged 1 commit into from
Feb 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Protocol validation for source map image type. ([#1869](https://github.com/getsentry/relay/pull/1869))
- Add PHP support for profiling. ([#1871](https://github.com/getsentry/relay/pull/1871))
- Add Javascript support for profiling. ([#1876](https://github.com/getsentry/relay/pull/1876))

**Internal**:

Expand Down
1 change: 1 addition & 0 deletions relay-profiling/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ pub use crate::outcomes::discard_reason;
enum Platform {
Android,
Cocoa,
Javascript,
Node,
Php,
Python,
Expand Down
4 changes: 3 additions & 1 deletion relay-profiling/src/sample.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ impl SampleProfile {
&& self.device.manufacturer.is_some()
&& self.device.model.is_some()
}
Platform::Python | Platform::Node | Platform::Php => self.runtime.is_some(),
Platform::Python | Platform::Javascript | Platform::Node | Platform::Php => {
self.runtime.is_some()
}
_ => true,
}
}
Expand Down