Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(general): Reject non http/https in help_link #192

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Apr 5, 2019

This rejects non http/https links in the system for help_link. Refs getsentry/sentry#12659

@mitsuhiko mitsuhiko requested a review from jan-auer April 5, 2019 07:37
@codecov-io
Copy link

Codecov Report

Merging #192 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   65.26%   65.33%   +0.06%     
==========================================
  Files          84       84              
  Lines        9130     9148      +18     
==========================================
+ Hits         5959     5977      +18     
  Misses       3171     3171
Impacted Files Coverage Δ
general/src/store/normalize/mechanism.rs 36.17% <100%> (+1.67%) ⬆️
general/src/store/normalize.rs 93.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60f87a...2d162ff. Read the comment docs.

@jan-auer jan-auer merged commit 7cf0cc4 into master Apr 5, 2019
@jan-auer jan-auer deleted the feature/reject-non-https branch April 5, 2019 11:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants