Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: Use jemalloc on Linux #2084

Merged
merged 3 commits into from
May 2, 2023
Merged

build: Use jemalloc on Linux #2084

merged 3 commits into from
May 2, 2023

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 2, 2023

Enables jemalloc as global allocator for Linux builds. This should reduce memory fragmentation and reclaim unused memory quicker, which is expected to lower Relay's overall memory footprint.

Relay's processing profile frequently moves memory between threads and also spawns threads on the fly. To allow the allocator to reclaim this memory efficiently, we also enable the background_threads option. See jemalloc/jemalloc#1128 (comment) for a mention of this.

See #344
See #1817

@jan-auer jan-auer requested a review from a team May 2, 2023 08:31
@jan-auer jan-auer self-assigned this May 2, 2023
@jan-auer jan-auer added filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date labels May 2, 2023
* master:
  ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081)
  feat(crons): Pass-through minimal `sdk` field (#2073)
  fix(quota): Parse large limits (#2079)
  instr(server): More details on unexpected envelope drop (#2077)
  fix(ci): Skip flaky integration test (#2076)
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start off the deploy with a Canary deploy.

@jan-auer jan-auer merged commit 9474e3f into master May 2, 2023
@jan-auer jan-auer deleted the build/jemalloc branch May 2, 2023 09:02
jan-auer added a commit that referenced this pull request May 9, 2023
* master: (178 commits)
  ref(crons): Allow `_` in monitor slugs (#2100)
  fix(span-metrics): Scrub subdomains in metric tags (#2103)
  feat(normalization): Scrub span description URLs (#2095)
  feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091)
  ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092)
  feat(protocol): Support old effective-directory format (#2048)
  ref(spans): Add more tags to span metrics (#2090)
  fix(server): Support HTTP half-close connections (#2089)
  ref(spans): Use transactions namespace with `span` prefix (#2087)
  ref(spans): Update span metrics feature flag name (#2086)
  feat(metrics): Extract more metrics from spans (#2080)
  build: Bump tempfile to remove flagged dependency (#2085)
  feat(filter): Add document_uri csp filter (#2059)
  build: Use jemalloc on Linux (#2084)
  ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081)
  feat(crons): Pass-through minimal `sdk` field (#2073)
  fix(quota): Parse large limits (#2079)
  instr(server): More details on unexpected envelope drop (#2077)
  fix(ci): Skip flaky integration test (#2076)
  feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants