ref: Use different error message for empty strings in schema processing #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
May 24, 2023
relay-general/src/store/schema.rs
Outdated
| #[test] | ||
| fn test_nonempty_string() { | ||
| assert_nonempty_base::<String>(); | ||
| assert_nonempty_string::<String>(); |
There was a problem hiding this comment.
Can we make assert_nonempty_base expect a &str with the expected error message instead of duplicating the function?
There was a problem hiding this comment.
Great feedback. Thanks! 29a689e
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2137