-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(profiling): Reject profiles longer than 30s #2168
Merged
phacops
merged 9 commits into
master
from
pierre/profiling-reject-profiles-longer-than-30-seconds
Jun 2, 2023
Merged
feat(profiling): Reject profiles longer than 30s #2168
phacops
merged 9 commits into
master
from
pierre/profiling-reject-profiles-longer-than-30-seconds
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
approved these changes
May 31, 2023
jjbayer
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: There's already a bunch of unit tests in this file, you could copy-paste one to verify the new behavior.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
phacops
deleted the
pierre/profiling-reject-profiles-longer-than-30-seconds
branch
June 2, 2023 13:35
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.