Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(metrics): Move TrimmingProcessor to light normalization #2342

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Jul 21, 2023

Because the TrimmingProcessor is not part of light normalization, we extract the untrimmed transaction name from the payload, which then gets dropped by the aggregator.

Solution: Call TrimmingProcessor in light_normalize_event.

After deploying this, we have to keep an eye on the event.processing_time metric.

Fixes https://github.com/getsentry/team-ingest/issues/187

@jjbayer jjbayer marked this pull request as ready for review July 24, 2023 16:07
@jjbayer jjbayer requested a review from a team July 24, 2023 16:07
@jjbayer jjbayer changed the title fix(metrics): Use truncated transaction name in metrics tag fix(metrics): Move TrimmingProcessor to light normalization Jul 24, 2023
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light normalization will soon replace everything

@jjbayer
Copy link
Member Author

jjbayer commented Jul 25, 2023

Light normalization will soon replace everything

Yep I would like to revert the split between light normalization and store normalization eventually!

@jjbayer jjbayer enabled auto-merge (squash) July 25, 2023 09:47
@jjbayer jjbayer merged commit b6a1531 into master Jul 25, 2023
19 checks passed
@jjbayer jjbayer deleted the fix/txname-truncation branch July 25, 2023 10:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants