fix(profiles): Bump android-trace-log version to prevent panic #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Sep 4, 2023
| @@ -15,7 +15,7 @@ debug = true | |||
|
|
|||
| [workspace.dependencies] | |||
| anyhow = "1.0.66" | |||
| chrono = { version = "0.4.24", default-features = false, features = [ | |||
| chrono = { version = "0.4.28", default-features = false, features = [ | |||
There was a problem hiding this comment.
android_trace_log uses a chrono function that is not available in 0.4.24.
| @@ -130,7 +130,8 @@ impl UnixTimestamp { | |||
|
|
|||
| /// Returns the timestamp as chrono datetime. | |||
| pub fn as_datetime(self) -> Option<DateTime<Utc>> { | |||
| NaiveDateTime::from_timestamp_opt(self.0 as i64, 0).map(|n| DateTime::from_utc(n, Utc)) | |||
| NaiveDateTime::from_timestamp_opt(self.0 as i64, 0) | |||
| .map(|n| DateTime::from_naive_utc_and_offset(n, Utc)) | |||
There was a problem hiding this comment.
from_utc is deprecated since chrono 0.4.27. The function does the same under the hood.
iker-barriocanal
approved these changes
Sep 4, 2023
TBS1996
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
@iker-barriocanal he wrote a test in android_trace_log if that counts 😛 https://github.com/chayleaf/android-trace-log/pull/2/files
@iker-barriocanal the test would replicate the one that @TBS1996 linked, so it would not add value IMO. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2451.
See also chayleaf/android-trace-log#2.