Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(librelay): Support global config normalization #2498

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

iker-barriocanal
Copy link
Contributor

@iker-barriocanal iker-barriocanal commented Sep 8, 2023

Exposes a global config normalization function. This is to be used for validating a correct global config.

Normalization consists of deserializing and serializing back a global config. The serialized output looks like what Relay forwards downstream, and an exception is thrown if the input is unparsable.

@iker-barriocanal iker-barriocanal self-assigned this Sep 8, 2023
@iker-barriocanal iker-barriocanal requested a review from a team September 8, 2023 10:36
py/sentry_relay/processing.py Outdated Show resolved Hide resolved
relay-cabi/src/processing.rs Outdated Show resolved Hide resolved
py/sentry_relay/processing.py Outdated Show resolved Hide resolved
py/tests/test_processing.py Outdated Show resolved Hide resolved
py/sentry_relay/processing.py Outdated Show resolved Hide resolved
relay-cabi/src/processing.rs Outdated Show resolved Hide resolved
py/tests/test_processing.py Outdated Show resolved Hide resolved
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, but please take a look at my latest suggestions.

@iker-barriocanal iker-barriocanal merged commit 71365b4 into master Sep 11, 2023
18 checks passed
@iker-barriocanal iker-barriocanal deleted the iker/feat/librelay-globalconfig branch September 11, 2023 07:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants