Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cabi): Remove dynamic sampling abi #2515

Merged
merged 4 commits into from
Sep 14, 2023
Merged

fix(cabi): Remove dynamic sampling abi #2515

merged 4 commits into from
Sep 14, 2023

Conversation

TBS1996
Copy link
Contributor

@TBS1996 TBS1996 commented Sep 14, 2023 •
edited
Loading

  1. We are refactoring dynamic sampling in ref(sampling): Refactor dynamic sampling #2514, making these tests outdated.
  2. it references a dynamic sampling function id like to make private

#skip-changelog

@TBS1996 TBS1996 changed the title fix(cabi): Remove unused dynamic sampling abi fix(cabi): Remove dynamic sampling abi Sep 14, 2023
@TBS1996 TBS1996 marked this pull request as ready for review September 14, 2023 10:20
@TBS1996 TBS1996 requested a review from a team September 14, 2023 10:20
@TBS1996 TBS1996 enabled auto-merge (squash) September 14, 2023 11:22
@TBS1996 TBS1996 merged commit 6921d70 into getsentry:master Sep 14, 2023
19 checks passed
@TBS1996 TBS1996 mentioned this pull request Oct 3, 2023
Merged
TBS1996 added a commit that referenced this pull request Oct 3, 2023
@TBS1996 @jjbayer
chore(py): Bump python changelog (#2561)
5ffbd15 
Updating the python changelog to reflect the new samplingrule variant in
#2550, and removal of dynamic sampling ABI in #2515
 

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TBS1996 @jan-auer