fix(spans): Use db.system for SQL parsing #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Sep 26, 2023
| @@ -34,7 +34,7 @@ pub(crate) fn scrub_span_description(span: &mut Span, rules: &Vec<SpanDescriptio | |||
| ("db", _) => sql::scrub_queries( | |||
| span.data | |||
| .value() | |||
| .and_then(|d| d.get("system")) | |||
| .and_then(|d| d.get("db.system")) | |||
There was a problem hiding this comment.
| .and_then(|d| d.get("description.scrubbed")) | ||
| .and_then(|v| v.value()) | ||
| .and_then(|v| v.as_str()); | ||
| assert_eq!(scrubbed, Some("SELECT %s")); |
There was a problem hiding this comment.
Without the fix, this would be SELECT not an identifier, because the default parser would assume that double quotes delimit an identifier.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL parser used for span description normalization and grouping accessed the wrong field to pick the SQL dialect. This bug did not durface in unit tests, because I passed the system string into those tests directly.