ref: Selectively log internal errors to stderr #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Oct 29, 2019
|
I fixed the tests. Seems like Relay now reports more errors on (forceful) shutdown than previously, which is probably a good thing. The regular graceful shutdown still behaves the same (raising no errors) |
tonyo
approved these changes
Oct 29, 2019
|
before we merge this @jan-auer please review the changes I made |
|
Looks good, thanks @untitaker |
jan-auer
added a commit
that referenced
this pull request
Nov 4, 2019
* master: (26 commits) doc: Add documentation about the path of an event through relay (#289) release: 0.4.59 meta: Changelog for 0.4.59 ref: Set _relay_processed to true (#293) feat(protocol): Add valid platforms as constant (#294) fix(protocol): Add missing legacy alias for stacktrace (#292) release: 0.4.58 meta: Add changelog for 0.4.58 feat: Expose globbing code from Semaphore to Python (#288) fix: Add code comment fix: Normalize before datascrubbing (#290) feat(projects): Evict project caches after some time (#287) feat: Add mkdocs like in symbolicator ref: Add event size metrics (#286) test: add panic test ref: Selectively log internal errors to stderr (#285) fix(cabi): Do not ignore process_value result in scrub_event (#284) feat(config): Add a config value for thread counts (#283) fix: Refactor outcomes for parity with Sentry (#282) feat: Add an error boundary to parsing project states (#281) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're logging quite a few errors now for events that are being filtered or rate limited. Most importantly, actix automatically logs all errors returned from endpoint futures.
This PR changes this, so that errors are logged selectively to stderr if they are considered "server" or "internal" errors, and otherwise either swallowed or logged to INFO.