Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(spans): Parse timestamps from strings #2857

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Dec 15, 2023

From the OpenTelemetry docs:

JSON Protobuf encoded payloads use proto3 standard defined JSON Mapping for mapping between Protobuf and JSON

From the protobuf docs:

JSON value will be a decimal string. Either numbers or strings are accepted.

@phacops phacops requested a review from jjbayer December 15, 2023 16:27
@phacops phacops requested a review from a team as a code owner December 15, 2023 16:27
@jjbayer jjbayer merged commit ac3df08 into master Dec 18, 2023
21 checks passed
@jjbayer jjbayer deleted the pierre/spans-string-or-integer branch December 18, 2023 08:46
jan-auer added a commit that referenced this pull request Dec 19, 2023
* master: (35 commits)
  fix(spans): Parse quotes in MySQL (#2846)
  ref(cardinality): Use a Lua script and in-memory cache for the cardinality limiter (#2849)
  fix(spans): Detect hex with fallback scrubber (#2868)
  release: 23.12.0
  Revert "ci: Update upload-artifact and download-artifact actions" (#2866)
  Revert "build: Update axum and http" (#2863)
  feat(spans): Allow resource.img spans (#2855)
  build: Update axum and http (#2844)
  fix(build): Add additional dependencies to the release build (#2858)
  ci: Update upload-artifact and download-artifact actions (#2861)
  feat(spans): Parse timestamps from strings (#2857)
  fix(spans): Scrub integer file extensions (#2856)
  feat(spans): Remove unused transaction tag from resource metrics (#2853)
  ref(cardinality): Recover buckets on cardinality limiter failure (#2852)
  feat(server): Org rate limit per metric bucket (#2836)
  ref(spans): List metric tags explicitly (#2834)
  feat(spans): Resource response sizes as measurements (#2845)
  feat(crons): Add thresholds to monitor config payload (#2842)
  feat(spans): Allow ingestion of metrics summary on spans (#2823)
  ref(crons): Add documentation to CheckInMessageType (#2840)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants