Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(spans): Collapse constants in SQL select #2867

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix(spans): Collapse constants in SQL select #2867

merged 3 commits into from
Dec 19, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Dec 19, 2023 •
edited
Loading

Before:

SELECT foo, bar, NULL, baz FROM my_table
-- became
SELECT  .., %s, baz FROM my_table

After:

SELECT foo, bar, NULL, baz FROM my_table
-- becomes
SELECT .. FROM my_table

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review December 19, 2023 09:09
@jjbayer jjbayer requested a review from a team as a code owner December 19, 2023 09:09
gggritso
gggritso approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjbayer jjbayer merged commit 3662370 into master Dec 19, 2023
20 checks passed
@jjbayer jjbayer deleted the fix/spans-sql-select-null branch December 19, 2023 15:56
jan-auer added a commit that referenced this pull request Dec 20, 2023
@jan-auer
Merge branch 'master' into feat/batch-metrics-endpoint
8d309ee 
* master:
  feat(processor): Add a metric to track the time of all messages (#2877)
  build(py): Update to python 3.9 (#2876)
  fix(spans): Collapse constants in SQL select (#2867)
  fix(spans): Parse quotes in MySQL (#2846)
  ref(cardinality): Use a Lua script and in-memory cache for the cardinality limiter (#2849)
  fix(spans): Detect hex with fallback scrubber (#2868)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@olksdr olksdr olksdr approved these changes

@gggritso gggritso gggritso approved these changes

@Dav1dde Dav1dde Dav1dde approved these changes

@phacops phacops Awaiting requested review from phacops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjbayer @Dav1dde @gggritso @olksdr @iker-barriocanal