fix(metrics): Fetch project config when metrics are received #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
commented
Jan 23, 2024
|
|
||
| let project = self.get_or_create_project(message.project_key()); | ||
| project.prefetch(project_cache, false); | ||
| project.merge_buckets( |
There was a problem hiding this comment.
Without this change, the added integration test fails.
Comment on lines
+714
to
+716
| // TODO: When the state is present but expired, we should send buckets | ||
| // to the metrics buffer instead. In practice, the project state should be | ||
| // refreshed at the time when the buckets emerge from the aggregator though. |
There was a problem hiding this comment.
I think we should do this, but I'll leave it for a follow-up.
jjbayer
commented
Jan 23, 2024
| {"buckets": {public_key: metrics}}, | ||
| ) | ||
|
|
||
| envelope = mini_sentry.captured_events.get(timeout=3) |
There was a problem hiding this comment.
This .get() fails without the prefetch.
Dav1dde
approved these changes
Jan 24, 2024
Dav1dde
reviewed
Jan 24, 2024
| message.buckets(), | ||
| ); | ||
|
|
||
| let project = self.get_or_create_project(message.project_key()); |
There was a problem hiding this comment.
I wonder if we should just always prefetch in get_or_create_project. I found the same "bug" for metric metadata as well.
There was a problem hiding this comment.
@Dav1dde I would even go further and unify the multiple state enums we have for project configs at the moment:
GetOrFetch- either a cached project config or a channelState- either a cached project config or a metrics bufferExpiryState- eitherUpdated,Stale, orExpired
We might be able to make a single enum out of these, and give them an interface that makes it impossible to access a project without prefetching.
TBS1996
approved these changes
Jan 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics that arrive through the global metrics endpoint do not currently trigger a refetch of the project config. If a single processing relay only receives metrics traffic (no envelopes) for a specific project, metrics might get stuck in the pre-aggregator a.k.a. metrics buffer.
ref: #2967.