feat(spans): Tag duration by group for all ops supporting description scrubbing #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
reviewed
Apr 4, 2024
Zylphrex
reviewed
Apr 4, 2024
...traction/snapshots/relay_server__metrics_extraction__event__tests__extract_span_metrics.snap
Outdated
Show resolved
Hide resolved
jjbayer
approved these changes
Apr 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make comparison between spans of the same group, we need to start tagging the duration metric by group as well. That way, we'll be able to indicate, for a given op + description, if the span was faster or slower.
This will increase cardinality for this metric, putting it on part with what we have for exclusive time.