feat(spans): Add event. getters for Span #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
May 10, 2024
Comment on lines
+114
to
+116
| let span_prefix = path.strip_prefix("span."); | ||
| if let Some(span_prefix) = span_prefix { | ||
| return Some(match span_prefix { |
There was a problem hiding this comment.
match path.split_once('.') {
Some(("span", remainder)) => { /* ... */ },
Some(("event", remainder)) => { /* ... */ },
_ => return None
}
Dav1dde
approved these changes
May 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional fields to the
SpanGetterimplementation with the same path as theEventfields. The rationale behind this is to allow backward compatibility of rules that work on events, to now work on spans.Close: #3551