Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(spans): Detect db_system redis #3642

Merged
merged 3 commits into from
May 24, 2024
Merged

fix(spans): Detect db_system redis #3642

merged 3 commits into from
May 24, 2024

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented May 24, 2024

It seems that javascript V8 sends span.op: db with span.data.db_system: redis. We need to treat this case like db.redis to prevent identifiers ending up in metrics storage unscrubbed.

@jjbayer jjbayer marked this pull request as ready for review May 24, 2024 07:37
@jjbayer jjbayer requested a review from a team as a code owner May 24, 2024 07:37
@jjbayer jjbayer enabled auto-merge (squash) May 24, 2024 10:34
@jjbayer jjbayer merged commit 0c98dbd into master May 24, 2024
22 checks passed
@jjbayer jjbayer deleted the fix/spans-skip-redis branch May 24, 2024 10:56
@jjbayer jjbayer mentioned this pull request Jul 8, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

@mwarkentin mwarkentin mwarkentin approved these changes

@gggritso gggritso Awaiting requested review from gggritso

@DominikB2014 DominikB2014 Awaiting requested review from DominikB2014

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjbayer @mwarkentin @Dav1dde