Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(event-schema): Look up data attributes in tags #3751

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat(event-schema): Look up data attributes in tags #3751

merged 2 commits into from
Jun 20, 2024

Conversation

jan-auer
Copy link
Member

SDKs send certain attributes in span.tags rather than span.data. To
consolidate access and make all data accessible via a single key, this PR makes
the getter implementation on spans fall back to tags if a key is not present
on data.

Fixes #3748

@jan-auer jan-auer requested a review from a team as a code owner June 20, 2024 08:25
@jan-auer jan-auer self-assigned this Jun 20, 2024
@jan-auer jan-auer merged commit 6f5b38f into master Jun 20, 2024
22 checks passed
@jan-auer jan-auer deleted the feat/span-data-tags branch June 20, 2024 09:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract metrics from span tags if it's not in span data
2 participants
@jan-auer @iambriccardo