Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(normalization): Added parsing of raw OS description for iOS and iPadOS coming from Unity #3780

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

bitsandfoxes
Copy link
Contributor

The Unity SDK reports the OS via raw description in the following format:

Mac OS X 14.4.1
iPadOS 17.5.1
iOS 17.5.1
Android OS 14 / API-34 (AP2A.240605.024/11860263)

The context normalization deals just fine with macOS and Android but skips iOS and iPadOS and sets the version into the kernel_version instead. This seems to lead to missing os tags as reported by a user:
image

Looking at the automatically created tags I get

"tags": [
    [
      "device",
      "Mac15,8"
    ],
    [
      "os",
      "macOS 14.4.1"
    ],
    [
      "os.name",
      "macOS"
    ],
  ],

and

"tags": [
    [
      "device",
      "Google Pixel 6"
    ],
    [
      "os",
      "Android 14"
    ],
    [
      "os.name",
      "Android"
    ],
  ],

for macOS and Android but end up with only os.name on the mobile devices:

  "tags": [
    [
      "device",
      "iPad11,1"
    ],
    [
      "os.name",
      "iPadOS"
    ],
  ],

The deleted test also indicates, that this behaviour is not necessarily intentional in the first place.

@bitsandfoxes bitsandfoxes requested a review from a team as a code owner July 2, 2024 12:21
@bitsandfoxes bitsandfoxes changed the title fix: Added parsing of raw OS description for iOS and iPadOS coming from Unity fix(normalization): Added parsing of raw OS description for iOS and iPadOS coming from Unity Jul 2, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit 1da2930 into master Jul 2, 2024
22 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/unity-raw-os-descriptions branch July 2, 2024 15:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants