fix(proxy): Keep spans, profiles, and replays in proxy mode #3888
Conversation
| @@ -798,6 +798,9 @@ struct ProcessEnvelopeState<'a, Group> { | |||
| /// The state of the project that this envelope belongs to. | |||
| project_state: Arc<ProjectInfo>, | |||
|
|
|||
| /// The config of this Relay instance. | |||
| config: Arc<Config>, | |||
There was a problem hiding this comment.
We did not have the config on the state but passed it into all the processing functions which needed it.
For example:
relay/relay-server/src/services/processor.rs
Lines 1686 to 1690 in 77ffd71
Do we want to replace all of these now as well?
| /// but we want to forward them in proxy mode. | ||
| fn feature_disabled_by_upstream(&self, feature: Feature) -> bool { | ||
| match self.config.relay_mode() { | ||
| RelayMode::Proxy | RelayMode::Static | RelayMode::Capture => false, |
There was a problem hiding this comment.
Is this correct for all feature flags?
If not: Possibly we make project.has_feature() require a &Config as argument?
There was a problem hiding this comment.
I think this logic only makes sense for feature flags that are used to filter data. I.e. it would not make sense to assume that a feature is enabled for something like Feature::DoExpensiveAndDangerousExperimentalStuff in proxies. Do you think I should just rename this function to should_filter?
Fixes #3800