Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(spans): tag resource specific metrics with user.geo.subregion #3934

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

DominikB2014
Copy link
Contributor

work towards getsentry/sentry#75230

This should allow all the asset module to be filtered down on user subregion.

@DominikB2014 DominikB2014 marked this pull request as ready for review August 14, 2024 17:45
@DominikB2014 DominikB2014 requested a review from a team as a code owner August 14, 2024 17:45
@DominikB2014 DominikB2014 enabled auto-merge (squash) August 14, 2024 17:46
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but have you checked the span cardinality after your latest addition? According to some Relay stats (nothing really concrete) it looks like it changed quite drastically. Maybe better to check cardinality first.

@DominikB2014 DominikB2014 merged commit ca3dd18 into master Aug 19, 2024
24 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/tag-asset-metrics-with-geolocation branch August 19, 2024 07:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants