Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(eap): Extract user IP #4144

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat(eap): Extract user IP #4144

merged 2 commits into from
Oct 16, 2024

Conversation

Zylphrex
Copy link
Member

This starts extracting user IP from the transaction into sentry tags.

This starts extracting user IP from the transaction into sentry tags.
@Zylphrex Zylphrex requested a review from a team October 15, 2024 14:36
@Zylphrex Zylphrex requested a review from a team as a code owner October 15, 2024 14:36
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the IP need to be indexed? If not, we can also put it in span.data.

@Zylphrex
Copy link
Member Author

Does the IP need to be indexed? If not, we can also put it in span.data.

The intention is to have it indexed

@Zylphrex Zylphrex merged commit 7fbf4ca into master Oct 16, 2024
23 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/extract-user-ip branch October 16, 2024 14:50
jan-auer added a commit that referenced this pull request Oct 21, 2024
* master:
  ref(server): Move project source into the source module (#4154)
  instr(buffer): Measure envelope size (#4153)
  ref(redis): Cleanup code around Redis (#4151)
  lint: Rust 1.82 (#4150)
  chore(server): Remove native placeholders from transaction processing (#4148)
  feat(eap): Extract user IP (#4144)
  Revert "ref(buffer): remove peek" (#4146)
  ref(buffer): remove peek (#4136)
  release: 24.10.0
  build(deps): bump tonic from 0.12.2 to 0.12.3 (#4143)
  instr(projects): Log fetch failure (#4142)
  ref(otel): Disable default features for otel schema (#4141)
  ref(server): Organize project services in nested modules (#4139)
  ref(redis): Update to redis client version 0.27.4 (#4132)
  feat(redis): Implement parallel cmd execution of Redis calls (#4118)
  feat(spooler): Add metric to track serialization performance (#4135)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants