fix(server): Validate session timestamps #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
Jun 24, 2020
jan-auer
force-pushed
the
fix/validate-session-timestamps
branch
from
5a53f31
to
c29a7e9
Compare
|
Is this to prevent the issue we had yesterday with negative received dates? If yes, are you planning to remove the special case we added to the snuba connsumer ? https://github.com/getsentry/snuba/blob/master/snuba/datasets/sessions_processor.py#L53-L56 |
|
@fpacifici I'll leave that up to you and Snuba owners. There's probably not much harm in keeping it, and it adds some visibility, in case this ever regresses in the future. |
|
ok, will leave it there, then. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds clock drift correction and validates session timestamps. Previously, only the
startedtimestamp was validated.The maximum session age was previously hardcoded and can now be configured via processing settings. As part of this, the validation code has moved into the
EventProcessor, where all other normalization code is executed.