feat(py): Expose DataCategory via C-ABI #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
commented
Jul 7, 2020
py/sentry_relay/consts.py
Outdated
| Returns categories that count as traditional error tracking events. | ||
| """ | ||
| return frozenset( | ||
| DataCategory.DEFAULT, DataCategory.ERROR, DataCategory.SECURITY |
There was a problem hiding this comment.
Note that this changes compared to Sentry, where SECURITY was not included:
This is mainly used by quotas, which will now include security events as originally intended.
| SpanStatus::Unimplemented => write!(f, "unimplemented"), | ||
| SpanStatus::Unavailable => write!(f, "unavailable"), | ||
| SpanStatus::InternalError => write!(f, "internal_error"), | ||
| SpanStatus::Unknown => write!(f, "unknown"), |
There was a problem hiding this comment.
This is now changed from "unknown_error", along with all other uses.
| runtime_props.misc_primary_cpu_brand = None; | ||
| #[allow(deprecated)] | ||
| { | ||
| runtime_props.misc_primary_cpu_brand = None; |
There was a problem hiding this comment.
This is fixes an existing warning, unrelated to this patch.
jan-auer
commented
Jul 7, 2020
| if not attr.startswith(prefix): | ||
| continue | ||
|
|
||
| status_name = attr[len(prefix) :].lower() |
There was a problem hiding this comment.
I would say this is actually safe - per convention the constants must always match the default serialization. That said, if we ever diverge from this in the future (which we should not!) we can call into an API for this.
untitaker
approved these changes
Jul 8, 2020
| if not attr.startswith(prefix): | ||
| continue | ||
|
|
||
| status_name = attr[len(prefix) :].lower() |
untitaker
approved these changes
Jul 8, 2020
jan-auer
added a commit
that referenced
this pull request
Jul 8, 2020
This was referenced Jul 8, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
DataCategoryvia the C-ABI to Python for consumption in Sentry and Snuba. Along with this, also exposes theSpanStatus, still via the old dictionary. In a future change, this could be made an enum, too.To expose the constants, they have been moved to
relay-cabi. Unfortunately, a limitation in cbindgen does not allow to parserelay-generaldirectly. On the upside, this creates a central place for constants that are exposed from Relay to other services in Sentry.Along with this, the deprecated serialization of span status
"unknown_error"is removed. By now, all downstream consumers have been updated.