Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(store): Improve tag normalization #808

Merged
merged 5 commits into from
Oct 16, 2020
Merged

fix(store): Improve tag normalization #808

merged 5 commits into from
Oct 16, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Oct 13, 2020 •
edited
Loading

Instead of removing entire tag pairs, keep the key and value in place and attach meta data to the individual field.

Do not merge this yet, this requires getsentry/snuba#1419.

@jan-auer jan-auer requested a review from a team October 13, 2020 12:48
@jan-auer jan-auer self-assigned this Oct 13, 2020
This was referenced Oct 13, 2020
Merged
Merged
@jan-auer
Merge branch 'master' into fix/normalize-tags
f492a39 
* master:
  ref(pii): Use external utf16string crate (#807)
  feat(pii): Merge padding and masking characters (#810)
  fix(server): Rate limit outcomes emited only for events on "fast-path" (#809)
  fix(server): Rate limit outcomes emited only for events (#806)
@jan-auer
meta: Changelog
0db97b9
@jan-auer
Copy link
Member Author

Going to merge this after the OSS 20.10.0 release. Relay binary changelog still pending.

@jan-auer
Merge branch 'master' into fix/normalize-tags
741219f 
* master:
  ci(gha): Mark version as optional in release workflow (#813)
  ci(docker): Rename latest tag to nightly (#812)
  release: 20.10.0
@jan-auer
meta: Changelog
0d3443d
@jan-auer jan-auer merged commit 985fb06 into master Oct 16, 2020
@jan-auer jan-auer deleted the fix/normalize-tags branch October 16, 2020 06:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

@untitaker untitaker Awaiting requested review from untitaker

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @mitsuhiko