feat(protocol): Add protocol support for WASM #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2020
jan-auer
approved these changes
Nov 27, 2020
| @@ -126,6 +126,9 @@ pub struct Frame { | |||
| /// then symbolication can take place. | |||
| pub instruction_addr: Annotated<Addr>, | |||
|
|
|||
| /// Defines the addressing mode for addresses. | |||
| pub addr_mode: Annotated<String>, | |||
There was a problem hiding this comment.
We should consider validating the format here, but I think it's fine to merge as string.
| @@ -377,13 +377,11 @@ pub struct NativeDebugImage { | |||
| /// Starting memory address of the image (required). | |||
| /// | |||
| /// Memory address, at which the image is mounted in the virtual address space of the process. Should be a string in hex representation prefixed with `"0x"`. | |||
| #[metastructure(required = "true")] | |||
There was a problem hiding this comment.
Does this work with the sentry processor as is? I think we may expect non-null values at some places in native/processing.py or native/symbolicator.py.
There was a problem hiding this comment.
Looked into this, and it will work. There are two places in AppleCrashReport rendering where we would throw None ValueErrors.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the protocol for WASM. In the frame you can now provide
addr_modeto override the behavior of an address. For instance one can set this torel:indexto set it relative to the index of a debug image. This is all handled in the background in sentry.Refs getsentry/symbolicator#301