feat(server): Ingest and normalize sample rates #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lobsterkatie please double-check the test and the schema. |
* master: fix(server): Normalize user reports during ingestion (#903)
jan-auer
force-pushed
the
feat/ingest-sample-rates
branch
from
33c7250
to
625d2d0
Compare
Looks good. Do the other possible values for the method ('explicitly_set' and 'inheritance') just get ignored for the moment? (Which is fine - just want to make sure they don't break things.) |
|
@lobsterkatie not sure if I understand correctly, do you mean if we accept other values for "id"? The identifier can be any value because is defined as string like this: id: Annotated<String> |
|
Yup, that was my question, thanks. We're good. |
untitaker
approved these changes
Jan 14, 2021
RaduW
approved these changes
Jan 14, 2021
jan-auer
added a commit
that referenced
this pull request
Jan 27, 2021
* master: fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913) release: 21.1.0 ci: Fix clippy command invocation ci: Run clippy via the cargo action feat(server): Ingest and normalize sample rates (#910)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to look at the sample rate users set for specific events and
transactions. In regular mode, Relay takes the sample rates from the effective
event item and forwards them to the upstream. In processing mode, the sample
rates are instead written into
_metrics.The JavaScript SDK implements this with getsentry/sentry-javascript#3068.