feat(metrics): Remove timestamp from text protocol #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Apr 6, 2021
relay-metrics/src/lib.rs
Outdated
| //! Clients submit metrics in a [text-based protocol](Metric) based on StatsD. A sample submission | ||
| //! looks like this: | ||
| //! Clients submit metrics in envelopes containing a [text-based protocol](Metric) based on StatsD. | ||
| //! A sample submission looks like this: |
There was a problem hiding this comment.
Can we split this up into the text-based protocol, and then the Envelope protocol, like we had in Notion? It's good to keep the examples to the text portion of it, since that is StatsD compatible and we might want to introduce a new endpoint that takes this as plain text input.
…ther timestamp or date string
jan-auer
approved these changes
Apr 12, 2021
relay-common/Cargo.toml
Outdated
| @@ -26,6 +26,9 @@ sentry-types = "0.20.0" | |||
| schemars = { version = "0.8.1", features = ["uuid", "chrono"], optional = true } | |||
| serde = { version = "1.0.114", features = ["derive"] } | |||
|
|
|||
| [dev-dependencies] | |||
| serde_test = "" | |||
There was a problem hiding this comment.
Suggested change
| serde_test = "" | |
| serde_test = "1.0.125" |
CHANGELOG.md
Outdated
| @@ -18,7 +19,7 @@ | |||
| - Emit the `quantity` field for outcomes of events. This field describes the total size in bytes for attachments or the event count for all other categories. A separate outcome is emitted for attachments in a rejected envelope, if any, in addition to the event outcome. ([#942](https://github.com/getsentry/relay/pull/942)) | |||
| - Add experimental metrics ingestion without bucketing or pre-aggregation. ([#948](https://github.com/getsentry/relay/pull/948)) | |||
| - Skip serializing some null values in frames interface. ([#944](https://github.com/getsentry/relay/pull/944)) | |||
| - Add experimental metrics ingestion with bucketing and pre-aggregation. ([#948](https://github.com/getsentry/relay/pull/948), [#952](https://github.com/getsentry/relay/pull/952), [#958](https://github.com/getsentry/relay/pull/958), [#966](https://github.com/getsentry/relay/pull/966), [#969](https://github.com/getsentry/relay/pull/969)) | |||
| - Add experimental metrics ingestion with bucketing and pre-aggregation. ([#948](https://github.com/getsentry/relay/pull/948), [#952](https://github.com/getsentry/relay/pull/952), [#958](https://github.com/getsentry/relay/pull/958), [#966](https://github.com/getsentry/relay/pull/966), [#969](https://github.com/getsentry/relay/pull/969)). | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
'12345678.9) from the text protocol,timestamptoItemHeaders, which can be submitted as date string or number,Metric::serialize()function(cannot serialize to text protocol without dropping timestamp).