Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Combined Dynamic Sampling #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Combined Dynamic Sampling #111

wants to merge 3 commits into from

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 29, 2023

Reduce the number of profiles and replays dropped through dynamic sampling by
changing how trace sampling decisions are computed.

Rendered RFC

@jan-auer jan-auer self-assigned this Aug 29, 2023
@smeubank
Copy link
Member

it looks good, but what i miss from RFCs often is some kind of diagram to help visualize what we are talking about.

then something more like a use case that is a concrete user example: sub trace for example I don't really understand what this means. Sampling on the individual events? There is no trace?

@JoshFerge JoshFerge requested review from a team and jas-kas August 29, 2023 15:37
@jan-auer
Copy link
Member Author

@JoshFerge This RFC is not yet ready for review, it's still in draft state.

the sample rates permit, and dynamic sampling will prefer to store traces with
all data available.

## Sub-Trace Sampling
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section will be revisited. Following a conversation with @mydea, we will keep the replay sample rate completely independent of trace sampling (however subject to RFC 109). I'll write up a revision of this section that takes necessary changes into account.

@JoshFerge
Copy link
Member

@JoshFerge This RFC is not yet ready for review, it's still in draft state.

got it. sorry about that. it's an exciting one :D

@JoshFerge JoshFerge removed request for a team and jas-kas August 29, 2023 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants