ref: Remove currentHub from SentrySDK #1019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove SentrySDK.currentHub and SentrySDK.setCurrentHub, which are only
needed internally and by hybrid SDKs. They are not intended to be public API.
This breaks Hybrid SDKs, but we are going to fix this with adding
captureEnvelope
andstoreEnvelope
toSentrySDK.m
but not in the header. The hybrid SDKs can create a category to make these two methods accessible. We use this pattern for the test initializers already.💡 Motivation and Context
See getsentry/develop#248 (comment)
💚 How did you test it?
CI.
📝 Checklist
🔮 Next steps