ref: Improve envelope API for Hybrid SDKs #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add captureEnvelope and storeEnvelope to SentrySDK.m, so hybrid SDKs have a nicer API to interact. The hybrid SDKs can create a category to make these two methods accessible. We use this pattern for the test initializers already. Make SentryClient.storeEnvelope private.
marandaneto
approved these changes
Mar 25, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add captureEnvelope and storeEnvelope to SentrySDK.m, so hybrid SDKs
have a nicer API to interact. The hybrid SDKs can create a category to make
these two methods accessible. We use this pattern for the test initializers
already. Make SentryClient.storeEnvelope private.
💡 Motivation and Context
getsentry/develop#248 (comment)
💚 How did you test it?
Units tests.
📝 Checklist
🔮 Next steps