Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ref: Align SentryException with unified API #1026

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

philipphofmann
Copy link
Member

📜 Description

Replace SentryException.thread with threadId and stacktrace. This aligns
SentryException with the exception interface, see
https://develop.sentry.dev/sdk/event-payloads/exception/.

💡 Motivation and Context

We want to align the SDK with our spec.

💚 How did you test it?

CI and simulator.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the CHANGELOG if needed
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Replace SentryException.thread with threadId and stacktrace. This aligns
SentryException with the exception interface, see
https://develop.sentry.dev/sdk/event-payloads/exception/.
@philipphofmann philipphofmann requested a review from a team March 26, 2021 09:04
@philipphofmann philipphofmann added this to the 7.0.0 milestone Mar 26, 2021
@codecov-io
Copy link

Codecov Report

Merging #1026 (4e9c2eb) into master (c74fc40) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 4e9c2eb differs from pull request most recent head 9d11092. Consider uploading reports for the commit 9d11092 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
- Coverage   95.31%   95.29%   -0.03%     
==========================================
  Files          92       92              
  Lines        4034     4036       +2     
==========================================
+ Hits         3845     3846       +1     
- Misses        189      190       +1     
Impacted Files Coverage Δ
Sources/Sentry/SentryCrashReportConverter.m 95.03% <100.00%> (+0.03%) ⬆️
Sources/Sentry/SentryException.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryThreadInspector.m 96.29% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd52a7...9d11092. Read the comment docs.

@philipphofmann philipphofmann enabled auto-merge (squash) March 26, 2021 09:21
@philipphofmann philipphofmann merged commit 6c84794 into master Mar 26, 2021
@philipphofmann philipphofmann deleted the ref/sentry-exception branch March 26, 2021 10:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants