-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Remove Check for Original Method Call When Swizzling #1383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
- Coverage 95.61% 95.44% -0.17%
==========================================
Files 152 152
Lines 5515 6743 +1228
==========================================
+ Hits 5273 6436 +1163
- Misses 242 307 +65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome you managed to get rid of the duplicated code.
Using try-catch in ObjC is not recommended, and our solution to check whether any swizzled method calls the original implementation uses one.
To not use this solution in release, a build configuration was created for tests, and we do this check only in tests.
Once the tests confirm that swizzled methods call the original implementation, we don't need to have this check on release.
Fixes GH-1368