-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Crash when reading corrupted envelope #4297
Conversation
…tsentry/sentry-cocoa into fix/unserialize-envelope-item
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
135dec6 | 1236.67 ms | 1255.13 ms | 18.45 ms |
42f4107 | 1224.52 ms | 1244.77 ms | 20.25 ms |
25bcc50 | 1237.69 ms | 1258.40 ms | 20.71 ms |
253bb71 | 1221.62 ms | 1250.82 ms | 29.20 ms |
699d76f | 1217.12 ms | 1236.33 ms | 19.20 ms |
4b1113e | 1239.04 ms | 1250.45 ms | 11.41 ms |
7cd187e | 1239.39 ms | 1258.02 ms | 18.63 ms |
e758449 | 1243.41 ms | 1246.71 ms | 3.31 ms |
aa4eddf | 1228.21 ms | 1236.72 ms | 8.51 ms |
06bac56 | 1213.62 ms | 1236.27 ms | 22.65 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
135dec6 | 21.58 KiB | 615.19 KiB | 593.61 KiB |
42f4107 | 21.58 KiB | 614.92 KiB | 593.34 KiB |
25bcc50 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
253bb71 | 20.76 KiB | 393.37 KiB | 372.60 KiB |
699d76f | 21.58 KiB | 631.82 KiB | 610.24 KiB |
4b1113e | 21.58 KiB | 697.83 KiB | 676.25 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
e758449 | 22.85 KiB | 407.62 KiB | 384.77 KiB |
aa4eddf | 21.58 KiB | 544.86 KiB | 523.28 KiB |
06bac56 | 22.84 KiB | 403.23 KiB | 380.39 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4297 +/- ##
=============================================
+ Coverage 91.684% 91.696% +0.011%
=============================================
Files 617 617
Lines 50194 50205 +11
Branches 18116 18119 +3
=============================================
+ Hits 46020 46036 +16
+ Misses 4083 4076 -7
- Partials 91 93 +2
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
📜 Description
Added a safe guard to prevent crashing when reading corrupted envelope
💡 Motivation and Context
This was mentioned in #4280
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps