-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[v9]: bump drift min version and use QueryInterceptor
instead of QueryExecutor
#2679
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
d43bab3
temp
buenaflor 0c64554
update
buenaflor 9870881
update
buenaflor 21e2bc9
update docs
buenaflor 93d28b2
update
buenaflor 83dab13
Update sentry.dart
buenaflor 4c2a339
Merge branch 'v9' into v9-task/bump-drift-and-use-interceptor
buenaflor 14774eb
update CHANGELOG
buenaflor 95a662f
Merge branch 'v9' into v9-task/bump-drift-and-use-interceptor
buenaflor 7bff992
update
buenaflor 485f2eb
fist tests
buenaflor 4c04496
formatting
buenaflor 7a37b9d
fix analyze
buenaflor fa7f0a0
fix analyze
buenaflor fa3a450
Merge branch 'v9' into v9-task/bump-drift-and-use-interceptor
buenaflor 0179511
Merge branch 'v9' into v9-task/bump-drift-and-use-interceptor
buenaflor c7c6e0c
formatting and change integration name from to
buenaflor b3b1d73
improve ensureOpen instrumentation
buenaflor 28e8693
fix hub not using hubadapter as fallback
buenaflor c6e6e48
update parent span
buenaflor 2af04c5
use stack to handle parent span
buenaflor 95bbec9
formatting
buenaflor 5950868
Merge branch 'v9' into v9-task/bump-drift-and-use-interceptor
buenaflor 5220270
formatting
buenaflor 0a19ad6
fix analyze
buenaflor 758ab6e
add disabled tracing test
buenaflor b131634
unused code
buenaflor a2d1d76
temp
buenaflor 05827f9
update
buenaflor 64285d3
add test
buenaflor 9d76492
remove spotlight
buenaflor 6e6b02d
cleanup test file
buenaflor 1646e4d
add select query test:
buenaflor 8b59210
removing stack in finally block
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import 'package:meta/meta.dart'; | ||
|
||
@internal | ||
class SentrySpanOperations { | ||
static const String uiLoad = 'ui.load'; | ||
static const String uiTimeToInitialDisplay = 'ui.load.initial_display'; | ||
static const String uiTimeToFullDisplay = 'ui.load.full_display'; | ||
static const String dbSqlQuery = 'db.sql.query'; | ||
static const String dbSqlTransaction = 'db.sql.transaction'; | ||
static const String dbSqlBatch = 'db.sql.batch'; | ||
static const String dbOpen = 'db.open'; | ||
static const String dbClose = 'db.close'; | ||
} | ||
|
||
@internal | ||
class SentrySpanData { | ||
static const String dbSystemKey = 'db.system'; | ||
static const String dbNameKey = 'db.name'; | ||
|
||
static const String dbSystemSqlite = 'db.sqlite'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tbd in other PR, add other db systems here |
||
} | ||
|
||
@internal | ||
class SentrySpanDescriptions { | ||
static const String dbTransaction = 'Transaction'; | ||
static String dbBatch({required List<String> statements}) => | ||
'Batch $statements'; | ||
static String dbOpen({required String dbName}) => 'Open database $dbName'; | ||
static String dbClose({required String dbName}) => 'Close database $dbName'; | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
library; | ||
|
||
export 'src/sentry_query_executor.dart'; | ||
export 'src/sentry_query_interceptor.dart'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
const String integrationName = 'sentryDriftTracing'; | ||
const String loggerName = 'sentry_drift'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbd in other PR, remove
SpanDataConvention
and put the constants here