fix: navigation breadcrumb with missing to crashes native
#2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
+ Coverage 88.99% 92.15% +3.16%
==========================================
Files 263 91 -172
Lines 8921 2946 -5975
==========================================
- Hits 7939 2715 -5224
+ Misses 982 231 -751 ☔ View full report in Codecov by Sentry. |
vaind
force-pushed
the
fix/replay-failure-navigation-breadcrumb
branch
from
a4e9e7c to
2e476b8
Compare
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| affcf07 | 1240.61 ms | 1266.49 ms | 25.88 ms |
| ca7f531 | 1242.51 ms | 1282.61 ms | 40.10 ms |
| b56b25c | 1243.67 ms | 1265.38 ms | 21.70 ms |
| 0db91cc | 1267.63 ms | 1279.69 ms | 12.06 ms |
| 25e9b59 | 1289.76 ms | 1295.27 ms | 5.51 ms |
| ab99a31 | 1247.24 ms | 1280.60 ms | 33.35 ms |
| 519423f | 1240.80 ms | 1260.88 ms | 20.08 ms |
| 1c926c2 | 1246.82 ms | 1263.15 ms | 16.33 ms |
| 8a7f528 | 1232.57 ms | 1249.82 ms | 17.24 ms |
| 8bac8ba | 1261.53 ms | 1279.67 ms | 18.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| affcf07 | 8.38 MiB | 9.70 MiB | 1.33 MiB |
| ca7f531 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| b56b25c | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| 0db91cc | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
| 25e9b59 | 8.16 MiB | 9.15 MiB | 1021.15 KiB |
| ab99a31 | 8.38 MiB | 9.78 MiB | 1.41 MiB |
| 519423f | 8.10 MiB | 9.16 MiB | 1.06 MiB |
| 1c926c2 | 8.42 MiB | 9.89 MiB | 1.47 MiB |
| 8a7f528 | 8.10 MiB | 9.16 MiB | 1.06 MiB |
| 8bac8ba | 8.42 MiB | 9.89 MiB | 1.47 MiB |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
| 9e7630d | 449.43 ms | 475.82 ms | 26.39 ms |
| e2d89fc | 323.84 ms | 376.23 ms | 52.39 ms |
| 7c7c64f | 442.35 ms | 492.79 ms | 50.44 ms |
| b44db8f | 307.77 ms | 366.41 ms | 58.64 ms |
| b8562d0 | 362.31 ms | 437.27 ms | 74.96 ms |
| 408bdab | 360.18 ms | 434.92 ms | 74.74 ms |
| be173fa | 375.94 ms | 458.36 ms | 82.42 ms |
| 7f2b01d | 304.94 ms | 345.71 ms | 40.78 ms |
| a43c400 | 492.55 ms | 558.31 ms | 65.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
| 9e7630d | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| e2d89fc | 6.06 MiB | 7.03 MiB | 989.37 KiB |
| 7c7c64f | 6.49 MiB | 7.57 MiB | 1.08 MiB |
| b44db8f | 6.16 MiB | 7.14 MiB | 1003.72 KiB |
| b8562d0 | 6.35 MiB | 7.33 MiB | 1005.53 KiB |
| 408bdab | 6.27 MiB | 7.20 MiB | 959.07 KiB |
| be173fa | 6.35 MiB | 7.33 MiB | 1005.54 KiB |
| 7f2b01d | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| a43c400 | 6.46 MiB | 7.48 MiB | 1.03 MiB |
vaind
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
buenaflor
added a commit
that referenced
this pull request
Feb 19, 2025
buenaflor
added a commit
that referenced
this pull request
Feb 19, 2025
7 tasks
buenaflor
added a commit
that referenced
this pull request
Feb 20, 2025
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 --------- Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
fixes #2719
fixes #2721
💡 Motivation and Context
💚 How did you test it?
manually by setting the navigation breadcrumb
data.tofield tonullin theRouteObserverBreadcrumb📝 Checklist
sendDefaultPiiis enabled🔮 Next steps