-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: cleanup platform mocking #2730
base: v9
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2730 +/- ##
==========================================
+ Coverage 87.16% 87.21% +0.05%
==========================================
Files 175 176 +1
Lines 5966 5985 +19
==========================================
+ Hits 5200 5220 +20
+ Misses 766 765 -1 ☔ View full report in Codecov by Sentry. |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- cleanup platform mocking ([#2730](https://github.com/getsentry/sentry-dart/pull/2730)) If none of the above apply, you can opt out of this check by adding |
Isn't the platform checker used to decide which native integration is called? So actually returning true for 'isMacOs' on web would cause the macos integrations to be called on web? |
I believe that was the case in the past but looking at how the code which calls
|
doesn't seem related to the changes in this PR |
we recently added hints to transactions, looks like flutter tests weren't updated cc @denrase |
📜 Description
part of #2646
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps