-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[python] document new rust_tracing integration #11842
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[python] document new rust_tracing integration #11842
Conversation
@matt-codecov is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a technical perspective: very nice!
Docs team will also do a review to make sure the English and the voice is OK.
|
||
</Alert> | ||
|
||
## Supported Versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matt-codecov Do you think it might be worth moving the 'supported versions' section to the top, right above the 'install' section? I feel like this info might be good to know right off the bat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i followed the structure of other integration pages and the ones i read all had this at the bottom
i am not even positive these are the correct minimum versions. i have not tested this with every rust/python version since the listed ones here, i just copied the minimum versions imposed by one of the dependencies (PyO3) since other integrations all had this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding! Included a couple suggestions, but looks good to go 🫡
addressed the missing "configuring" and the broken link aside from needing another vercel preview (which i'm not authorized to do @coolguyzone), the release of the Python SDK with this change in it has not actually gone out yet. i'll follow up here to merge after that happens |
A new Python SDK integration was created in getsentry/sentry-python#3717 + getsentry/sentry-python#3780 and this PR documents it.
DESCRIBE YOUR PR
A new Python SDK integration was created in getsentry/sentry-python#3717 + getsentry/sentry-python#3780 and this PR documents it.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES