Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RN: Adds RN Expo Sentry Android Gradle Plugin subpage #12371

Merged
merged 13 commits into from
Feb 20, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 16, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Part of getsentry/sentry-react-native#4400
Related RN PR: getsentry/sentry-react-native#4440

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Should be merged after getsentry/sentry-react-native#4440 is released

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:51am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 11:51am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 11:51am

Copy link

codecov bot commented Jan 16, 2025

Bundle Report

Changes will increase total bundle size by 69.64kB (0.34%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.01MB 69.64kB (0.64%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/JLsKq_FTPXidfouF35OBD/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/JLsKq_FTPXidfouF35OBD/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/efvdzgzag94_4GjfPM-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/efvdzgzag94_4GjfPM-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 23.14kB 1.73MB 1.35%
../instrumentation.js 23.14kB 1.07MB 2.22%
9523.js 23.14kB 1.04MB 2.27%
../app/[[...path]]/page.js.nft.json 71 bytes 379.11kB 0.02%
../app/platform-redirect/page.js.nft.json 71 bytes 379.02kB 0.02%
../app/sitemap.xml/route.js.nft.json 71 bytes 377.0kB 0.02%

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge it once a a new released with the new feature gets released

@coolguyzone coolguyzone requested a review from romtsn January 21, 2025 17:48
Comment on lines 37 to 45
The supported [Sentry Android Gradle Plugin options](/platforms/android/configuration/gradle/) are the following:
- `autoUploadProguardMapping`
- `includeProguardMapping`
- `dexguardEnabled`
- `uploadNativeSymbols`
- `autoUploadNativeSymbols`
- `includeNativeSources`
- `includeSourceContext`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace the list of the options with a section under the code snippet of the options with a description of the functionality.

For example how we do it in

## Options
You can configure the instrumentation by passing an options object to the constructor:
```javascript
Sentry.reactNativeNavigationIntegration({
navigation: Navigation, // Navigation from `react-native-navigation`
routeChangeTimeoutMs: 1_000, // default: 1_000
enableTabsInstrumentation: true, // default: false
ignoreEmptyBackNavigationTransactions: true, // default: true
});
```
### navigation
This option is required and should be the `Navigation` object imported from the navigation library.
### routeChangeTimeoutMs
This option specifies how long the instrumentation will wait for the route to mount after a change has been initiated before the transaction is discarded. The default value is `1_000`.
### enableTabsInstrumentation
This instrumentation will create a transaction on tab change. By default, only navigation commands create transactions. The default value is `false`.
### ignoreEmptyBackNavigationTransactions
This ensures that transactions that are from routes that've been seen and don't have any spans, are not being sampled. This removes a lot of clutter, making it so that most back navigation transactions are now ignored. The default value is `true`.

The description already exists in https://sentry-docs-3s3vjrwvt.sentry.dev/platforms/android/configuration/gradle/ so we can just copy it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @krystofwoldrich 👍
Updated with 193fa06

@krystofwoldrich
Copy link
Member

I would name the file gradle.mdx the same way we do in the Android docs.

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Feb 20, 2025

We should add Expo SAGP page also to the next steps on the Expo page

## Next Steps
- [Learn how to upload source maps for native builds and Expo Updates](/platforms/react-native/sourcemaps/uploading/expo/)
- [Add automatic tracing with Expo Router](/platforms/react-native/tracing/instrumentation/expo-router/)

antonis and others added 3 commits February 20, 2025 13:08
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Copy link
Collaborator Author

antonis commented Feb 20, 2025

Thank you for your feedback @krystofwoldrich 🙇

I would name the file gradle.mdx the same way we do in the Android docs.

Renamed with 9cad7c0

We should add Expo SAGP page also to the next steps on the Expo page

Updated with 33daace

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀, thank you!

@krystofwoldrich krystofwoldrich merged commit cc5c5a5 into master Feb 20, 2025
11 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/rn-expo-sagp branch February 20, 2025 14:34
@krystofwoldrich
Copy link
Member

The SDK changes released today in https://github.com/getsentry/sentry-react-native/releases/tag/6.8.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants