-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
RN: Adds RN Expo Sentry Android Gradle Plugin subpage #12371
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 69.64kB (0.34%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge it once a a new released with the new feature gets released
The supported [Sentry Android Gradle Plugin options](/platforms/android/configuration/gradle/) are the following: | ||
- `autoUploadProguardMapping` | ||
- `includeProguardMapping` | ||
- `dexguardEnabled` | ||
- `uploadNativeSymbols` | ||
- `autoUploadNativeSymbols` | ||
- `includeNativeSources` | ||
- `includeSourceContext` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace the list of the options with a section under the code snippet of the options with a description of the functionality.
For example how we do it in
sentry-docs/docs/platforms/react-native/tracing/instrumentation/react-native-navigation.mdx
Lines 27 to 54 in 5873e41
## Options | |
You can configure the instrumentation by passing an options object to the constructor: | |
```javascript | |
Sentry.reactNativeNavigationIntegration({ | |
navigation: Navigation, // Navigation from `react-native-navigation` | |
routeChangeTimeoutMs: 1_000, // default: 1_000 | |
enableTabsInstrumentation: true, // default: false | |
ignoreEmptyBackNavigationTransactions: true, // default: true | |
}); | |
``` | |
### navigation | |
This option is required and should be the `Navigation` object imported from the navigation library. | |
### routeChangeTimeoutMs | |
This option specifies how long the instrumentation will wait for the route to mount after a change has been initiated before the transaction is discarded. The default value is `1_000`. | |
### enableTabsInstrumentation | |
This instrumentation will create a transaction on tab change. By default, only navigation commands create transactions. The default value is `false`. | |
### ignoreEmptyBackNavigationTransactions | |
This ensures that transactions that are from routes that've been seen and don't have any spans, are not being sampled. This removes a lot of clutter, making it so that most back navigation transactions are now ignored. The default value is `true`. |
The description already exists in https://sentry-docs-3s3vjrwvt.sentry.dev/platforms/android/configuration/gradle/ so we can just copy it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea @krystofwoldrich 👍
Updated with 193fa06
I would name the file |
We should add Expo SAGP page also to the next steps on the Expo page sentry-docs/docs/platforms/react-native/manual-setup/expo.mdx Lines 124 to 127 in 7432e6c
|
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Thank you for your feedback @krystofwoldrich 🙇
Renamed with 9cad7c0
Updated with 33daace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀, thank you!
The SDK changes released today in https://github.com/getsentry/sentry-react-native/releases/tag/6.8.0 |
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
Part of getsentry/sentry-react-native#4400
Related RN PR: getsentry/sentry-react-native#4440
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Should be merged after getsentry/sentry-react-native#4440 is released
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES