Skip to content

feat(js): Stop using provider.addSpanProcessor() #13011

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 17, 2025

This fixes some things pointed out in getsentry/sentry-javascript#15518, which are no longer compatible with OTEL v2. We already have a replacement for this in place.

@mydea mydea requested review from AbhiPrasad and andreiborza March 17, 2025 09:18
@mydea mydea self-assigned this Mar 17, 2025
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 9:33am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Mar 17, 2025 9:33am
develop-docs ⬜️ Ignored (Inspect) Mar 17, 2025 9:33am

Copy link

codecov bot commented Mar 17, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.54MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.16kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/VXX3EVHU0G3rHS9hygVOj/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/VXX3EVHU0G3rHS9hygVOj/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this already works with our setup!

@mydea mydea merged commit 223df75 into master Mar 17, 2025
11 checks passed
@mydea mydea deleted the fn/otel-apis-update branch March 17, 2025 09:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants