Skip to content

Fix broken link in Cloudflare docs #14017

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

KyleTryon
Copy link
Contributor

@KyleTryon KyleTryon commented Jun 12, 2025

[Cursor created PR - Reviewed by me]

Broken links in the Cloudflare configuration documentation have been resolved.

  • A new file, docs/platforms/javascript/common/configuration/integrations/fetchIntegration.mdx, was created.
    • This addresses a 404 error caused by a missing page referenced by fetchIntegration in the integrations table.
    • The file includes metadata, documentation for Sentry.fetchIntegration, configuration options (breadcrumbs, shouldCreateSpanForRequest), and usage examples, specifically noting its relevance to Cloudflare Workers.
  • The link for requestDataIntegration in platform-includes/configuration/integrations/javascript.cloudflare.mdx was updated.
    • The previous link, ./requestDataIntegration, had incorrect casing and pointed to a non-existent path.
    • The link was corrected to ./requestdata to match the actual filename requestdata.mdx, ensuring consistency with other integration links.

All links in the Cloudflare integrations table now correctly point to existing documentation files.

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 9:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 9:44pm

@KyleTryon
Copy link
Contributor Author

KyleTryon commented Jun 12, 2025

Located the source of the Cloudflare fetchIntegration

https://github.com/getsentry/sentry-javascript/blob/6b656b4009f8f8ec51f379ed517494a0deaaaeef/packages/cloudflare/src/integrations/fetch.ts#L114-L117

/**

  • Creates spans and attaches tracing headers to fetch requests.
    */

Here is the breadcrumbs boolean value that was correctly documented by cursor
https://github.com/getsentry/sentry-javascript/blob/6b656b4009f8f8ec51f379ed517494a0deaaaeef/packages/cloudflare/src/integrations/fetch.ts#L30C4-L30C24
shouldCreateSpanForRequest is just below.

It appears cursor properly read this file, or had some kind of RAG knowledge of it.

The options and usage subheadings seem to be not present in similar integration pages, but I do like their inclusion here. We should discuss if this style difference is important.

@KyleTryon KyleTryon changed the title Fix broken link in Cloudflare docs [draft] Fix broken link in Cloudflare docs Jun 12, 2025
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestions, looks good!

KyleTryon and others added 4 commits June 12, 2025 17:13
…tchIntegration.mdx

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…tchIntegration.mdx

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…tchIntegration.mdx

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…tchIntegration.mdx

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Copy link

codecov bot commented Jun 12, 2025

Bundle Report

Changes will increase total bundle size by 270 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.91MB 276 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 401.83kB -0.0%
static/GknkdGxOhT8v7SvNX7e9w/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/GknkdGxOhT8v7SvNX7e9w/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/2UYMZher5x9PrVjtFWl9V/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/2UYMZher5x9PrVjtFWl9V/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
../app/[[...path]]/page.js.nft.json 95 bytes 399.88kB 0.02%
../app/platform-redirect/page.js.nft.json 95 bytes 399.8kB 0.02%
../app/sitemap.xml/route.js.nft.json 95 bytes 397.77kB 0.02%

@vercel vercel bot temporarily deployed to Preview – sentry-docs June 12, 2025 21:44 Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants