-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(native): support modifying attachments after init #14019
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(native): support modifying attachments after init #14019
Conversation
@jpnurmi is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a section for "removing scoped attachments", as that is now handled via a returned reference, which is different enough from the options interface to justify a documentation example.
Otherwise, this looks good!
@JoshuaMoelans, can you authorize a test deployment for review? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
According to the bot, something went wrong, but the docs are visible here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DESCRIBE YOUR PR
Adds documentation for Native SDK PR
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES