Skip to content

feat(native): support modifying attachments after init #14019

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jun 12, 2025

DESCRIBE YOUR PR

Adds documentation for Native SDK PR

Platforms / Native / Enriching Events / Attachments

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jun 12, 2025

@jpnurmi is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@jpnurmi jpnurmi marked this pull request as ready for review June 13, 2025 08:16
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a section for "removing scoped attachments", as that is now handled via a returned reference, which is different enough from the options interface to justify a documentation example.

Otherwise, this looks good!

@supervacuus
Copy link
Collaborator

@JoshuaMoelans, can you authorize a test deployment for review?

Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ❌ Failed (Inspect) Jun 13, 2025 1:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2025 1:22pm

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Jun 13, 2025

According to the bot, something went wrong, but the docs are visible here:

https://sentry-docs-git-fork-jpnurmi-feat-native-attachments.sentry.dev/platforms/native/enriching-events/attachments/

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bruno-garcia bruno-garcia merged commit 8e259d2 into getsentry:master Jun 17, 2025
10 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants