Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Flush async counter #214

Merged
merged 6 commits into from
May 31, 2019
Merged

feat: Flush async counter #214

merged 6 commits into from
May 31, 2019

Conversation

bruno-garcia
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #214 into master will increase coverage by 0.16%.
The diff coverage is 79.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   88.48%   88.65%   +0.16%     
==========================================
  Files          81       81              
  Lines        1963     2018      +55     
==========================================
+ Hits         1737     1789      +52     
- Misses        226      229       +3
Impacted Files Coverage Δ
src/Sentry/Extensibility/HubAdapter.cs 95.45% <0%> (-4.55%) ⬇️
src/Sentry/Internal/Hub.cs 61.19% <0%> (-7.14%) ⬇️
src/Sentry/SentryClient.cs 95.06% <0%> (-1.19%) ⬇️
src/Sentry/Extensibility/DisabledHub.cs 100% <100%> (ø) ⬆️
src/Sentry/SentrySdk.cs 100% <100%> (ø) ⬆️
src/Sentry/Internal/OptionalHub.cs 76.19% <100%> (+1.19%) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 95.9% <92.3%> (-2.84%) ⬇️
...Sentry/Extensibility/DiagnosticLoggerExtensions.cs 84% <0%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d17229...0b407f5. Read the comment docs.

@bruno-garcia bruno-garcia mentioned this pull request May 31, 2019
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick

src/Sentry/SentryClient.cs Show resolved Hide resolved
@bruno-garcia bruno-garcia merged commit bc8b6bf into master May 31, 2019
@bruno-garcia bruno-garcia deleted the feat/flush-async-counter branch May 31, 2019 14:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants