Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Use stacktrace from calling thread #222

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

bruno-garcia
Copy link
Member

Relies on Sentry.Protocol version 2.0.0 which no longer has Stacktrace directly on SentryEvent.

Resolves #113

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #222 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   88.84%   88.89%   +0.05%     
==========================================
  Files          81       81              
  Lines        2017     2027      +10     
==========================================
+ Hits         1792     1802      +10     
  Misses        225      225
Impacted Files Coverage Δ
src/Sentry/Internal/MainSentryEventProcessor.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c83af...31cb7e2. Read the comment docs.

@bruno-garcia bruno-garcia force-pushed the feat/stacktrace-on-thread branch from ed4fcae to f598bd4 Compare June 3, 2019 19:48
@bruno-garcia bruno-garcia merged commit 153296f into master Jun 3, 2019
@bruno-garcia bruno-garcia deleted the feat/stacktrace-on-thread branch June 3, 2019 20:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign stacktrace from non exception to Threads instead of SentryEvent
3 participants